BUG: fix: list as index item does not raise
#61674
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Jun 22, 2025
Comment on lines
+570
to
+573
| # 60925 should raise when one of index's items is a list and others are not | ||
| if any(isinstance(el, list) for el in data) and not all( | ||
| isinstance(el, list) for el in data | ||
| ): |
There was a problem hiding this comment.
No non-hashable value should occur here. Instead, can you do this check on arr below, and only in the case it's (a) a NumPy array (not an ExtensionArray) and (b) of object dtype. Use pandas.core.dtypes.inference.is_hashable.
| @@ -71,9 +71,12 @@ def test_assign_index_sequences(self): | |||
| repr(df) | |||
|
|
|||
| # this travels an improper code path | |||
| # 60925 should raise when one of index's items is a list and others are not | |||
There was a problem hiding this comment.
Can you use GH#60925 throughout.
Comment on lines
+78
to
+79
| df.index = index | ||
| repr(df) |
There was a problem hiding this comment.
This looks like it should raise on the first line, is that right? If so, can you remove repr(df).
| @@ -749,6 +749,7 @@ Indexing | |||
| - Bug in :meth:`MultiIndex.insert` when a new value inserted to a datetime-like level gets cast to ``NaT`` and fails indexing (:issue:`60388`) | |||
| - Bug in printing :attr:`Index.names` and :attr:`MultiIndex.levels` would not escape single quotes (:issue:`60190`) | |||
| - Bug in reindexing of :class:`DataFrame` with :class:`PeriodDtype` columns in case of consolidated block (:issue:`60980`, :issue:`60273`) | |||
| - Bug in creating :class:`Index` with one item being a ``list`` among others that aren't (should raise ValueError) (:issue:`60925`) | |||
There was a problem hiding this comment.
Suggested change
| - Bug in creating :class:`Index` with one item being a ``list`` among others that aren't (should raise ValueError) (:issue:`60925`) | |
| - Bug in creating :class:`Index` with some items being a non-hashable; this now raises a ``ValueError`` (:issue:`60925`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index.drop_duplicates()is inconsistent for unhashable values #60925doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.Problem:
Index constructor was allowing creation of indexes where one of the index's item is a list (unhashable) while others are not lists.
Solution:
Added a check in the Index constructor for this case. Raise ValueError.
Added test to check if is raising correctly.
Changed a test that should raise.